alessandrobenedetti commented on code in PR #910:
URL: https://github.com/apache/solr/pull/910#discussion_r913065377
##########
solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:
##########
@@ -42,40 +40,33 @@
* Provides a field type to support Lucene's {@link
org.apache.lucene.document.KnnVectorField}. See
* {@link org.apache.lucene.search.KnnVectorQuery} for more details. It
supports a fixed cardinality
* dimension for the vector and a fixed similarity function. The default
similarity is
- * EUCLIDEAN_HNSW (L2). The default index codec format is specified in the
Lucene Codec constructor.
- * For Lucene 9.1 e.g. See {@link
org.apache.lucene.codecs.lucene91.Lucene91Codec} Currently {@link
- * org.apache.lucene.backward_codecs.lucene90.Lucene90HnswVectorsFormat} and
{@link
- * org.apache.lucene.codecs.lucene91.Lucene91HnswVectorsFormat} are supported
for advanced
- * hyper-parameter customisation. See {@link
org.apache.lucene.util.hnsw.HnswGraph} for more details
- * about the implementation. <br>
+ * EUCLIDEAN_HNSW (L2). The default algorithm is HNSW. For Lucene 9.1 e.g. See
{@link
+ * org.apache.lucene.util.hnsw.HnswGraph} for more details about the
implementation. <br>
* Only {@code Indexed} and {@code Stored} attributes are supported.
*/
public class DenseVectorField extends FloatPointField {
+ public static final String HNSW_ALGORITHM = "hnsw";
static final String KNN_VECTOR_DIMENSION = "vectorDimension";
static final String KNN_SIMILARITY_FUNCTION = "similarityFunction";
- static final String CODEC_FORMAT = "codecFormat";
+ static final String ALGORITHM = "knnAlgorithm";
static final String HNSW_MAX_CONNECTIONS = "hnswMaxConnections";
static final String HNSW_BEAM_WIDTH = "hnswBeamWidth";
private int dimension;
private VectorSimilarityFunction similarityFunction;
private VectorSimilarityFunction DEFAULT_SIMILARITY =
VectorSimilarityFunction.EUCLIDEAN;
- private String codecFormat;
+ private String algorithm;
Review Comment:
let's be consistent and use KNN_ALGORITHM and knnAlgorithm everywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
