alessandrobenedetti commented on code in PR #904: URL: https://github.com/apache/solr/pull/904#discussion_r905193102
########## solr/core/src/java/org/apache/solr/schema/DenseVectorField.java: ########## @@ -276,6 +276,11 @@ public Query getKnnVectorQuery(String fieldName, float[] vectorToSearch, int top return new KnnVectorQuery(fieldName, vectorToSearch, topK); } + public Query getKnnVectorQuery( Review Comment: Hi @cpoerschke , thanks for the suggestion, I would normally agree but being an "experimental" feature I think we can just keep it simple and do that here in this pull request. In this way, we'll avoid the complexity of having to create another pull request immediately after (and it's a matter of 1 version or another anyway) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org