cpoerschke commented on code in PR #904: URL: https://github.com/apache/solr/pull/904#discussion_r906238869
########## solr/core/src/java/org/apache/solr/search/QueryUtils.java: ########## @@ -215,4 +221,38 @@ public static Query combineQueryAndFilter(Query scoreQuery, Query filterQuery) { } } } + + /** + * Parse the filter queries in Solr request + * + * @param req Solr request + * @param fixNegativeQueries if true, negative queries are rewritten by adding a MatchAllDocs + * query clause + * @return and array of Query. If the request does not contain filter queries, returns an empty + * list. + * @throws SyntaxError if an error occurs during parsing + */ + public static List<Query> parseFilterQueries(SolrQueryRequest req, boolean fixNegativeQueries) + throws SyntaxError { + + String[] filterQueriesStr = req.getParams().getParams(CommonParams.FQ); + + if (filterQueriesStr != null) { + List<Query> filters = new ArrayList<>(filterQueriesStr.length); + for (String fq : filterQueriesStr) { + if (fq != null && fq.trim().length() != 0) { + QParser fqp = QParser.getParser(fq, req); + fqp.setIsFilter(true); Review Comment: Wondering if this could also be under a flag since not all existing callers currently do the `setIsFilter` call. ```suggestion if (setIsFilter) { fqp.setIsFilter(true); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org