col-panic commented on code in PR #890:
URL: https://github.com/apache/solr/pull/890#discussion_r968152823
##########
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java:
##########
@@ -598,12 +599,48 @@ protected JWTAuthenticationResponse authenticate(String
authorizationHeader) {
} else {
// Pull roles from separate claim, either as whitespace
separated list or as JSON
// array
- Object rolesObj = jwtClaims.getClaimValue(rolesClaim);
+ Object rolesObj;
+ if (rolesClaim.indexOf('.') > 0) {
Review Comment:
Interesting point. I don't think that dots are common in claims. Maybe we
could support, that a dot prepended with a backslash means the literal dot
instead of as a child resolver. Such that `my.roles` is ` "my":{"roles":[]}`
and `my\.roles` is `my.roles` - this could be done rather easily and also
easily be added to the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
