col-panic commented on code in PR #890:
URL: https://github.com/apache/solr/pull/890#discussion_r970319709
##########
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java:
##########
@@ -598,12 +599,48 @@ protected JWTAuthenticationResponse authenticate(String
authorizationHeader) {
} else {
// Pull roles from separate claim, either as whitespace
separated list or as JSON
// array
- Object rolesObj = jwtClaims.getClaimValue(rolesClaim);
+ Object rolesObj;
+ if (rolesClaim.indexOf('.') > 0) {
Review Comment:
What about changing
_Both top-level claim and nested claim is supported. Use `someClaim.child`
syntax to address a claim `child` nested within the `someClaim` object._
to
_Both top-level claim and nested claim is supported. Use `someClaim.child`
syntax to address the literal claim `someClaim.child` or, if it does not exist,
the claim `child` nested within the `someClaim` object._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
