[
https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615269#comment-17615269
]
Kevin Risden commented on SOLR-8803:
------------------------------------
[~elyograg] [^SOLR-8803-3.patch] looks reasonable. Few comments from reviewing:
*
https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/lang/RuntimePermission.html
"manageProcess" seems scary, but looks to be covered
https://docs.oracle.com/javase/9/docs/api/java/lang/ProcessHandle.html - if you
run Solr with a limited permissions user - shouldn't have access to other
processes on the box.
* maybe would be good to check if pid == 0 when doing the warn/info logging.
pid = 0 is usually init or systemd and would be highly misleading. It just
happens to be the default value configured if there is an exception. It would
be cleaner to maybe just say "we don't know the pid go look here for this
pattern".
> OOM killer for Windows
> ----------------------
>
> Key: SOLR-8803
> URL: https://issues.apache.org/jira/browse/SOLR-8803
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 9.0
> Reporter: Binoy Dalal
> Assignee: Shawn Heisey
> Priority: Minor
> Labels: OOM, oom
> Fix For: 9.2
>
> Attachments: SOLR-8803-1.patch, SOLR-8803-2.patch, SOLR-8803-3.patch,
> SOLR-8803.patch, oom_win.cmd
>
>
> Solr on windows does not currently have a script to kill the process on OOM
> errors.
> The idea is to write a batch script that works like the OOM kill script for
> Linux and kills the solr process on OOM errors while creating an OOM log file
> like the one on Linux systems.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
