ben-manes commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1296493503
I have [added](https://github.com/ben-manes/caffeine/commit/9cd509c69344e304eb3ff99fe61cd8810957e6e8) detection for the scenario when the key's equality has changed and corrupted the mapping. For put, putIfAbsent replace, remove, and computes this will throw an exception, whereas clear and eviction will log at the error level. The put's loop remains indefinite, but after a spin wait threshold it will fallback to a map computation. For the common case it adds no overhead, for a taxed system this yields so that the remover thread may be granted a time slice to finish its work, and for the corruption case it gives us a chance to terminate with a validation error. These changes are available in `3.1.2-SNAPSHOT` from the sonatype repository. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
