[
https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638273#comment-17638273
]
Eric Pugh commented on SOLR-16427:
----------------------------------
[~krisden] I was looking at some of the clean up work, and I was wondering if
this ticket is completed? Is the definition of "done" that all the rules in
[https://github.com/apache/solr/blob/main/gradle/validation/error-prone.gradle]
are either enabled, or have a comment on why they are OFF? It's a huge amount
of work that has gone into this, and I'm super happy that IntelliJ is flagging
so many fewer lines of code as warnings!
> Evaluate and fix errorprone rules
> ---------------------------------
>
> Key: SOLR-16427
> URL: https://issues.apache.org/jira/browse/SOLR-16427
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Priority: Major
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
> Errorprone has many rules and there are a bunch that are disabled in Solr.
> Some make sense to leave disabled. Others are just disabled because they
> weren't evaluated.
> See
> https://github.com/apache/solr/blob/main/gradle/validation/error-prone.gradle
> This was previously done for some rules in SOLR-15908 and SOLR-15613. This
> relates to SOLR-16364
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
