[
https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638342#comment-17638342
]
Robert Muir commented on SOLR-16427:
------------------------------------
I worked on a more thorough analysis of the rules here for lucene, maybe it is
helpful:
* https://github.com/apache/lucene/pull/11970
* https://github.com/apache/lucene/pull/11971
Maybe some of it is also useful to Solr. Strongly recommended: you have to look
at source code of each check to see what it is really doing. Majority of the
checks enabled in lucene were actually doing absolutely nothing (as they only
apply to google libraries/frameworks), merely slowing down builds. And all the
beneficial checks were actually disabled... worst of both worlds.
> Evaluate and fix errorprone rules
> ---------------------------------
>
> Key: SOLR-16427
> URL: https://issues.apache.org/jira/browse/SOLR-16427
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Priority: Major
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
> Errorprone has many rules and there are a bunch that are disabled in Solr.
> Some make sense to leave disabled. Others are just disabled because they
> weren't evaluated.
> See
> https://github.com/apache/solr/blob/main/gradle/validation/error-prone.gradle
> This was previously done for some rules in SOLR-15908 and SOLR-15613. This
> relates to SOLR-16364
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
