janhoy opened a new pull request, #1225: URL: https://github.com/apache/solr/pull/1225
https://issues.apache.org/jira/browse/SOLR-9509 I used a shellcheck plugin to IntelliJ to fix these. I skipped several suggestions since I don't want to use "new" switches for various tools which may break back-compat. These were : > SC2009 (info): Consider using pgrep instead of grepping ps output. > SC2162 (info): read without -r will mangle backslashes. Also you will still find complaints about this one > SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location. A few places we accept `$FOO` as string input from user, and then redefined as array `FOO = ("bar")`, which I guess is an anti pattern. I fixed it one place, but we still have some of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
