stillalex commented on PR #1253:
URL: https://github.com/apache/solr/pull/1253#issuecomment-1366979347

   suggested fix for the DelegationTokenHttpSolrClient 
https://github.com/stillalex/solr/commit/5086e0fe099d5c2fa5942c6b3f18b7d803370136
 . 
   
   The constructor code looks a bit iffy to me. does it really overwrite any 
existing param from the builder to set this single param? it can't be correct.
   ```
   setQueryParams(new TreeSet<>(Arrays.asList(DELEGATION_TOKEN_PARAM)));
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to