epugh commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1058612968
########## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ########## @@ -128,7 +128,7 @@ public class Http2SolrClient extends SolrClient { private static final List<String> errPath = Arrays.asList("metadata", "error-class"); private HttpClient httpClient; - private volatile Set<String> queryParams = Collections.emptySet(); + protected Set<String> queryParams = Set.of(); Review Comment: Thanks for the sharp eyes.. yeah, I got moving too fast. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org