risdenk commented on code in PR #1239:
URL: https://github.com/apache/solr/pull/1239#discussion_r1064698615
##########
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java:
##########
@@ -250,7 +251,7 @@ public FileVisitResult visitFile(Path file,
BasicFileAttributes attrs)
public FileVisitResult postVisitDirectory(Path dir, IOException
ioException) {
String relativePath = configDir.relativize(dir).toString();
if (!relativePath.isEmpty()) {
- filePaths.add(relativePath + "/");
+ filePaths.add(normalizePathToForwardSlash(relativePath +
File.separator));
Review Comment:
So this was normalizing to `/` just semi convolutedly. Fixed in
836f33ad38a2bcca839e37d63ff35a78acbee404 and added a comment there to clarify.
##########
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java:
##########
@@ -259,6 +260,14 @@ public FileVisitResult postVisitDirectory(Path dir,
IOException ioException) {
return filePaths;
}
+ private String normalizePathToForwardSlash(String path) {
+ return path.replace(File.separatorChar, '/');
+ }
+
+ private String normalizePathToOSSeparator(String path) {
+ return path.replace('/', File.separatorChar);
Review Comment:
Fixed in 836f33ad38a2bcca839e37d63ff35a78acbee404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
