[
https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679852#comment-17679852
]
Kevin Risden commented on SOLR-15616:
-------------------------------------
{quote}That is a ridiculous statement right there{quote}
I really hoped I wouldn't have to point out the obvious here but happy to do so:
* you made not 1 but 2 commits that broke the build - this is basic correctness
that you didn't even run gradlew check ahead of time
** you didn't put a PR
** you knew your checks weren't working and decided to push anyway
* You didn't read the messages in the build about localSettings being required
- this wasted my time for both broken builds and pointing out the messages that
are in the build
* After pointing out localSettings, the help about it, and more - you still
think that you know what is best. Please read the history on why localSettings
before making complaints about how things are for every build.
I'm no longer helping when the build is broken due to this behavior
[~ichattopadhyaya] - you broke the build multiple times. This is never ok.
Following your logic on other issues you should have reverted the change
immediately. Not continue to push broken commits.
> Allow thread metrics to be cached
> ---------------------------------
>
> Key: SOLR-15616
> URL: https://issues.apache.org/jira/browse/SOLR-15616
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: Ishan Chattopadhyaya
> Assignee: Ishan Chattopadhyaya
> Priority: Major
> Fix For: 9.2
>
> Attachments: SOLR-15616-2.patch, SOLR-15616-9x.patch,
> SOLR-15616.patch, SOLR-15616.patch
>
>
> Computing JVM metrics for threads can be expensive, and we should provide
> option to users to avoid doing so on every call to the metrics API
> (group=jvm).
> solr.xml:
> {code}
> <solr>
> <metrics enabled=true>
> <caching>
> <int name="threadsIntervalSeconds">2</int>
> </caching>
> ..
> </metrics>
> </solr>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
