[ 
https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679877#comment-17679877
 ] 

David Smiley commented on SOLR-15616:
-------------------------------------

Ishan, if "gradlew check" or precommit isn't working for you then I think that 
needs to be worked out somewhere on, say on the dev list or Slack where we can 
collectively assist.  Jenkins/CI is great but it's not our first line of 
defense – "gradlew check" (or precommit) is.  Using PRs would have helped (even 
if it's not mandatory) because GitHub actions will run them.  We committers 
must trust each other to do the _basic_ things like ensuring precommit passes 
before committing/pushing.

> Allow thread metrics to be cached
> ---------------------------------
>
>                 Key: SOLR-15616
>                 URL: https://issues.apache.org/jira/browse/SOLR-15616
>             Project: Solr
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Ishan Chattopadhyaya
>            Assignee: Ishan Chattopadhyaya
>            Priority: Major
>             Fix For: 9.2
>
>         Attachments: SOLR-15616-2.patch, SOLR-15616-9x.patch, 
> SOLR-15616.patch, SOLR-15616.patch, Screenshot from 2023-01-23 21-18-19.png
>
>
> Computing JVM metrics for threads can be expensive, and we should provide 
> option to users to avoid doing so on every call to the metrics API 
> (group=jvm).
> solr.xml:
> {code}
> <solr>
> <metrics enabled=true>
>   <caching>
>     <int name="threadsIntervalSeconds">2</int>
>   </caching>
> ..
> </metrics>
> </solr>
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to