dsmiley commented on code in PR #1303:
URL: https://github.com/apache/solr/pull/1303#discussion_r1084822103
##########
.github/workflows/solrj-test-crave.yml:
##########
@@ -0,0 +1,41 @@
+name: SolrJ Tests
+
+on:
+ pull_request:
+ branches:
+ - 'main'
+ paths:
+ - '.github/workflows/solrj-test.yml'
+ - 'solr/solrj/**'
+
+jobs:
+ test:
+ name: Run SolrJ Tests
+
+ runs-on: ubuntu-latest
+
+ steps:
+ # Setup
+ - uses: actions/checkout@v2
+ - name: Set up JDK 11
+ uses: actions/setup-java@v2
+ with:
+ distribution: 'temurin'
+ java-version: 11
+ java-package: jdk
+ - name: Grant execute permission for gradlew
+ run: chmod +x gradlew
+ - uses: actions/cache@v2
+ with:
+ path: |
+ ~/.gradle/caches
+ key: ${{ runner.os }}-gradle-solrj-${{ hashFiles('versions.lock') }}
+ restore-keys: |
+ ${{ runner.os }}-gradle-solrj-
+ ${{ runner.os }}-gradle-
+ - name: Get the Crave binary
+ run: curl -s
https://raw.githubusercontent.com/accupara/crave/master/get_crave.sh | bash -s
--
+ - name: Initialize gradle settings
+ run: ./crave run -- ./gradlew localSettings
Review Comment:
Half the number of available processors reported by the JVM; the JVM counts
hyper threads individually. Since 2x threads per core is common, our build
divided this by two to guess at the number of physical cores. Then this is
capped at 12. Logic is in `./gradle/generation/local-settings.gradle`. There
are lots of concurrent threads in the JVM so I this this approach of using
physical cores in spite of hyper threading makes sense. On a machine with 96
threads on 48 cores (which I used last weekend playing around on Crave.io), 48
gradle workers worked well (and so did 24).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
