dsmiley commented on code in PR #1303:
URL: https://github.com/apache/solr/pull/1303#discussion_r1084829522
##########
.github/workflows/tests-via-crave.yml:
##########
@@ -0,0 +1,38 @@
+name: Solr Tests
+
+on:
+ pull_request:
+ branches:
+ - 'main'
+
+jobs:
+ test:
+ name: Run Solr Tests using Crave.io resources
+
+ runs-on: ubuntu-latest
+
+ steps:
+ # Setup
+ - uses: actions/checkout@v2
+ - name: Set up JDK 11
+ uses: actions/setup-java@v2
+ with:
+ distribution: 'temurin'
+ java-version: 11
+ java-package: jdk
+ - name: Grant execute permission for gradlew
+ run: chmod +x gradlew
+ - uses: actions/cache@v2
+ with:
+ path: |
+ ~/.gradle/caches
+ key: ${{ runner.os }}-gradle-solrj-${{ hashFiles('versions.lock') }}
+ restore-keys: |
+ ${{ runner.os }}-gradle-solrj-
+ ${{ runner.os }}-gradle-
Review Comment:
I suspect we don't need any of this because we won't be running the build at
all on this GitHub Action machine.
##########
.github/workflows/tests-via-crave.yml:
##########
@@ -0,0 +1,38 @@
+name: Solr Tests
+
+on:
+ pull_request:
+ branches:
+ - 'main'
+
+jobs:
+ test:
+ name: Run Solr Tests using Crave.io resources
+
+ runs-on: ubuntu-latest
+
+ steps:
+ # Setup
+ - uses: actions/checkout@v2
+ - name: Set up JDK 11
+ uses: actions/setup-java@v2
+ with:
+ distribution: 'temurin'
+ java-version: 11
+ java-package: jdk
+ - name: Grant execute permission for gradlew
+ run: chmod +x gradlew
+ - uses: actions/cache@v2
+ with:
+ path: |
+ ~/.gradle/caches
+ key: ${{ runner.os }}-gradle-solrj-${{ hashFiles('versions.lock') }}
+ restore-keys: |
+ ${{ runner.os }}-gradle-solrj-
+ ${{ runner.os }}-gradle-
+ - name: Get the Crave binary
+ run: curl -s
https://raw.githubusercontent.com/accupara/crave/master/get_crave.sh | bash -s
--
+ - name: Initialize gradle settings
+ run: ./crave run -- ./gradlew localSettings
+ - name: Test the Solr Package
+ run: ./crave run -- './gradlew --max-workers=`nproc` test'
Review Comment:
```suggestion
run: ./crave run -- './gradlew --max-workers=`nproc` -Ptests.jvms=48
test'
```
I did some exploration and found that it's not enough to set the workers in
this way as the "tests.jvms" will default to the value in gradle.properties
which is again capped at 12. When I used 48 workers & test JVMs on this
machine, the tests finished in 5:45 which is awesome! If you wish we could use
nproc again thus 96 for both. I did one such build and it pegged the cpu but
then stalled out, probably due to misbehavior in a test or something. I
ultimately killed it. Could just be bad luck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
