dsmiley commented on PR #1218: URL: https://github.com/apache/solr/pull/1218#issuecomment-1418184560
This is ready! I'm looking to commit this Tuesday if I don't hear feedback to the contrary. Suggested CHANGES.txt: --------- SOLR-16573: Introduce EmbeddedSolrServerTestRule, a JUnit 4 TestRule for Solr testing. (Joshua Ouma, David Smiley) Suggested commit summary: --------- New SolrClientTestRule abstraction with one implementation: EmbeddedSolrServerTestRule EmbeddedSolrServerTestBase and AbstractEmbeddedSolrServerTestCase were modified to use this abstraction, and yet were also marked deprecated to encourage direct use of the rule. A solr.xml file is optional. Some of the affected tests will run more efficiently because (A) they no longer do file I/O to create a temporary solr-home because the rule is able to use existing solr homes and configSets in-place and because (B) initCore() can double-parse a solrconfig.xml and schema.xml. SolrTestCaseJ4 / SolrTestCase: Moved ObjectReleaseTracker checking to use a Rule so that it's compatible with Rules that use ObjectReleaseTracker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
