[ 
https://issues.apache.org/jira/browse/SOLR-16642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17688882#comment-17688882
 ] 

Vinayak Hegde commented on SOLR-16642:
--------------------------------------

Hi [~magibney] 
In this Lucene change [https://github.com/apache/lucene/pull/11998] we have 
some deprecated functions
we discussed that we should not touch as a part of this ticket.
but some of the tests are failing with this error
{code:java}
org.apache.solr.TestJoin > testRandomJoin FAILED
    java.lang.AssertionError: Terms are only supposed to be consumed in the 
thread in which they have been acquired. But was acquired in 
Thread[searcherExecutor-320-thread-1,5,TGRP-TestJoin] and consumed in 
Thread[TEST-TestJoin.testRandomJoin-seed#[CA39E6C650AD9BC9],5,TGRP-TestJoin].
        at 
__randomizedtesting.SeedInfo.seed([CA39E6C650AD9BC9:B3B32A72428A3529]:0)
        at 
org.apache.lucene.tests.index.AssertingLeafReader.assertThread(AssertingLeafReader.java:67)
        at 
org.apache.lucene.tests.index.AssertingLeafReader$AssertingTerms.iterator(AssertingLeafReader.java:248)
        at 
org.apache.lucene.index.ExitableDirectoryReader$ExitableTerms.iterator(ExitableDirectoryReader.java:791)
        at org.apache.lucene.index.MultiTerms.iterator(MultiTerms.java:186)
        at 
org.apache.solr.search.JoinQuery$JoinQueryWeight.getDocSetEnumerate(JoinQuery.java:280)
        at 
org.apache.solr.search.JoinQuery$JoinQueryWeight.getDocSet(JoinQuery.java:233)
        at 
org.apache.solr.search.JoinQuery$JoinQueryWeight.scorer(JoinQuery.java:161)
        at org.apache.lucene.search.Weight.bulkScorer(Weight.java:166)
        at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:770)
        at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:551)
        at 
org.apache.solr.search.SolrIndexSearcher.buildAndRunCollectorChain(SolrIndexSearcher.java:267)
        at 
org.apache.solr.search.SolrIndexSearcher.getDocListNC(SolrIndexSearcher.java:1861)
        at 
org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1678)
        at 
org.apache.solr.search.SolrIndexSearcher.search(SolrIndexSearcher.java:712)
        at 
org.apache.solr.handler.component.QueryComponent.doProcessUngroupedSearch(QueryComponent.java:1637)
        at 
org.apache.solr.handler.component.QueryComponent.process(QueryComponent.java:421)
        at 
org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:419)
        at 
org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:224)
        at org.apache.solr.core.SolrCore.execute(SolrCore.java:2890)
        at org.apache.solr.util.TestHarness.query(TestHarness.java:357)
        at org.apache.solr.util.TestHarness.query(TestHarness.java:337)
        at org.apache.solr.TestJoin.testRandomJoin(TestJoin.java:407)
        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at 
com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
        at 
com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
        at 
com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
        at 
com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
        at 
com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:80)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        at 
org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
        at 
org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
 {code}
I suspect this is because of this change 
[https://github.com/apache/lucene/blob/13803aa6ea7fee91f798cfeded4296182ac43a21/lucene/test-framework/src/java/org/apache/lucene/tests/index/AssertingLeafReader.java#L172]
which is part of [https://github.com/apache/lucene/pull/11998]

so, what's your thought on this?
should we include this change in this ticket? or am I missing something?

> upgrade Solr to use Lucene 9.5.0
> --------------------------------
>
>                 Key: SOLR-16642
>                 URL: https://issues.apache.org/jira/browse/SOLR-16642
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Priority: Minor
>              Labels: newdev
>
> Apache Lucene 9.5.0 was recently released: 
> [https://lists.apache.org/thread/g9wmdnyk53m1fgxgr8qtb8gf2rl9w4g4]
> This ticket is to upgrade Solr's Lucene dependency from 9.4.2 to the latest 
> 9.5.0 version.
> new or existing contributors interested in this ticket:
>  * please take a look at the documentation to see what's involved: 
> [https://github.com/apache/solr/blob/main/dev-docs/lucene-upgrade.md]
>  * optional: add a short note on this ticket to share your intention to work 
> on this
>  * make the upgrade changes (and of course do feel free to ask any questions 
> that may arise)
>  * open a pull request
> Solr committers, please could you:
>  * help review/merge/backport etc. the pull request for this ticket
>  * try and leave the upgrade itself as an opportunity for someone else to 
> also contribute to the project
> Thanks everyone!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to