risdenk commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1107551800
##########
solr/core/src/java/org/apache/solr/handler/component/TermVectorComponent.java:
##########
@@ -277,15 +277,15 @@ public void process(ResponseBuilder rb) throws
IOException {
if (null != fields) {
for (Map.Entry<String, FieldOptions> entry : fieldOptions.entrySet()) {
final String field = entry.getKey();
- final Terms vector = reader.getTermVector(docId, field);
+ final Terms vector = reader.termVectors().get(docId).terms(field);
Review Comment:
I think `reader.termVectors()` can be pulled out of the while loop? near
line 253
##########
solr/core/src/java/org/apache/solr/handler/component/ResponseLogComponent.java:
##########
@@ -92,7 +92,8 @@ protected void processIds(
Set<String> fields =
Collections.singleton(schema.getUniqueKeyField().getName());
for (DocIterator iter = dl.iterator(); iter.hasNext(); ) {
- sb.append(schema.printableUniqueKey(searcher.doc(iter.nextDoc(),
fields))).append(',');
+
sb.append(schema.printableUniqueKey(searcher.storedFields().document(iter.nextDoc(),
fields)))
Review Comment:
I think `searcher.storedFields()` can be pulled out of the for loop?
##########
solr/core/src/java/org/apache/solr/handler/component/TermVectorComponent.java:
##########
@@ -277,15 +277,15 @@ public void process(ResponseBuilder rb) throws
IOException {
if (null != fields) {
for (Map.Entry<String, FieldOptions> entry : fieldOptions.entrySet()) {
final String field = entry.getKey();
- final Terms vector = reader.getTermVector(docId, field);
+ final Terms vector = reader.termVectors().get(docId).terms(field);
if (vector != null) {
TermsEnum termsEnum = vector.iterator();
mapOneVector(docNL, entry.getValue(), reader, docId, termsEnum,
field);
}
}
} else {
// extract all fields
- final Fields vectors = reader.getTermVectors(docId);
+ final Fields vectors = reader.termVectors().get(docId);
Review Comment:
I think reader.termVectors() can be pulled out of the while loop? near line
253
##########
solr/core/src/java/org/apache/solr/handler/component/ResponseLogComponent.java:
##########
@@ -106,7 +107,7 @@ protected void processScores(
StringBuilder sb = new StringBuilder();
Set<String> fields =
Collections.singleton(schema.getUniqueKeyField().getName());
for (DocIterator iter = dl.iterator(); iter.hasNext(); ) {
- sb.append(schema.printableUniqueKey(searcher.doc(iter.nextDoc(),
fields)))
+
sb.append(schema.printableUniqueKey(searcher.storedFields().document(iter.nextDoc(),
fields)))
Review Comment:
I think `searcher.storedFields()` can be pulled out of the for loop?
probably reused with the one from line 95?
##########
solr/core/src/java/org/apache/solr/handler/component/MoreLikeThisComponent.java:
##########
@@ -390,7 +390,7 @@ NamedList<DocList> getMoreLikeThese(
DocListAndSet similarDocuments =
mltHelper.getMoreLikeThis(id, 0, rows, null, interestingTerms,
flags);
- String name = schema.printableUniqueKey(searcher.doc(id));
+ String name =
schema.printableUniqueKey(searcher.storedFields().document(id));
Review Comment:
`searcher.storedFields()` can be pulled out of the while loop?
##########
solr/core/src/java/org/apache/solr/handler/MoreLikeThisHandler.java:
##########
@@ -472,7 +472,7 @@ public NamedList<BooleanQuery>
getMoreLikeTheseQuery(DocList docs) throws IOExce
DocIterator iterator = docs.iterator();
while (iterator.hasNext()) {
int id = iterator.nextDoc();
- String uniqueId = schema.printableUniqueKey(reader.document(id));
+ String uniqueId =
schema.printableUniqueKey(reader.storedFields().document(id));
Review Comment:
`reader.storedFields()` should be pulled out of the while loop.
##########
solr/core/src/java/org/apache/solr/handler/admin/IndexSizeEstimator.java:
##########
@@ -388,7 +388,7 @@ private void estimateTermVectors(Map<String, Object>
result) throws IOException
if (liveDocs != null && !liveDocs.get(docId)) {
continue;
}
- Fields termVectors = leafReader.getTermVectors(docId);
Review Comment:
`leafReader.termVectors()` should be pulled out of the docId for loop
##########
solr/core/src/java/org/apache/solr/handler/admin/IndexSizeEstimator.java:
##########
@@ -612,7 +612,7 @@ private void estimateStoredFields(Map<String, Object>
result) throws IOException
if (liveDocs != null && !liveDocs.get(docId)) {
continue;
}
- leafReader.document(docId, visitor);
+ leafReader.storedFields().document(docId, visitor);
Review Comment:
`leafReader.storedFields()` should be pulled out of the docId for loop
##########
solr/core/src/test/org/apache/solr/search/function/TestOrdValues.java:
##########
@@ -96,7 +96,7 @@ private void doTestRank(String field, boolean inOrder) throws
Exception {
: "IC"; // smaller than all ids of docs in this test ("ID0001",
etc.)
for (int i = 0; i < h.length; i++) {
- String resID = s.doc(h[i].doc).get(ID_FIELD);
+ String resID = s.storedFields().document(h[i].doc).get(ID_FIELD);
Review Comment:
`s.storedFields()` should be pulled out of the for loop.
##########
solr/core/src/java/org/apache/solr/util/SolrPluginUtils.java:
##########
@@ -252,7 +252,7 @@ public static void optimizePreFetchDocs(
// get documents
DocIterator iter = docs.iterator();
for (int i = 0; i < docs.size(); i++) {
- searcher.doc(iter.nextDoc(), fieldFilter);
+ searcher.storedFields().document(iter.nextDoc(), fieldFilter);
Review Comment:
`searcher.storedFields()` should be pulled out of the for loop.
##########
solr/core/src/test/org/apache/solr/search/function/TestOrdValues.java:
##########
@@ -139,7 +139,7 @@ private void doTestExactScore(String field, boolean
inOrder) throws Exception {
ScoreDoc sd[] = td.scoreDocs;
for (int i = 0; i < sd.length; i++) {
float score = sd[i].score;
- String id = s.getIndexReader().document(sd[i].doc).get(ID_FIELD);
+ String id =
s.getIndexReader().storedFields().document(sd[i].doc).get(ID_FIELD);
Review Comment:
`s.getIndexReader().storedFields()` should be pulled out of the for loop.
##########
solr/core/src/java/org/apache/solr/util/SolrPluginUtils.java:
##########
@@ -409,7 +409,7 @@ public static NamedList<Explanation> getExplanations(
for (int i = 0; i < docs.size(); i++) {
int id = iterator.nextDoc();
- Document doc = searcher.doc(id);
+ Document doc = searcher.storedFields().document(id);
Review Comment:
`searcher.storedFields()` should be pulled out of the for loop.
##########
solr/core/src/test/org/apache/solr/uninverting/TestFieldCacheVsDocValues.java:
##########
@@ -175,7 +175,7 @@ public void testHugeBinaryValues() throws Exception {
BinaryDocValues s = FieldCache.DEFAULT.getTerms(ar, "field");
for (int docID = 0; docID < docBytes.size(); docID++) {
- Document doc = ar.document(docID);
+ Document doc = ar.storedFields().document(docID);
Review Comment:
`ar.storedFields()` should be pulled out of the for loop
##########
solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessor.java:
##########
@@ -60,7 +60,8 @@ public ClassificationUpdateProcessor(
ClassificationUpdateProcessorParams classificationParams,
UpdateRequestProcessor next,
IndexReader indexReader,
- IndexSchema schema) {
+ IndexSchema schema)
+ throws IOException {
Review Comment:
I see a bunch of these new `IOException` throws are they required?
##########
solr/core/src/java/org/apache/solr/core/QuerySenderListener.java:
##########
@@ -86,7 +86,7 @@ public void close() {}
if (o instanceof DocList) {
DocList docs = (DocList) o;
for (DocIterator iter = docs.iterator(); iter.hasNext(); ) {
- newSearcher.doc(iter.nextDoc());
+ newSearcher.storedFields().document(iter.nextDoc());
Review Comment:
`newSearcher.storedFields()` should be pulled out of the for loop.
##########
solr/core/src/test/org/apache/solr/handler/tagger/TaggerTestCase.java:
##########
@@ -144,7 +144,7 @@ protected TestTag[] pullTagsFromResponse(SolrQueryRequest
req, SolrQueryResponse
DocIterator iter = docList.iterator();
while (iter.hasNext()) {
int docId = iter.next();
- Document doc = searcher.doc(docId);
+ Document doc = searcher.storedFields().document(docId);
Review Comment:
`searcher.storedFields()` should be pulled out of the for loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
