vinayakphegde commented on PR #1360:
URL: https://github.com/apache/solr/pull/1360#issuecomment-1432998084
> Sharing early here (not immediately sure about the _right_ way to fix
this); it looks like there's a problem with `Terms` caching in
`SlowCompositeReaderWrapper`; tests pass (aside from the test that explicitly
tests for `Terms` caching in `SlowCompositeReaderWrapper` 🙂) with:
>
> ```diff
> diff --git
a/solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java
b/solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java
> index f638fbd664f..5765b1e6d71 100644
> ---
a/solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java
> +++
b/solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java
> @@ -140,6 +140,9 @@ public final class SlowCompositeReaderWrapper extends
LeafReader {
> public Terms terms(String field) throws IOException {
> ensureOpen();
> try {
> + if (true) {
> + return MultiTerms.getTerms(in, field);
> + }
> return cachedTerms.computeIfAbsent(
> field,
> f -> {
> ```
>
> I also happened to hit an unrelated reproducible failure:
>
> ```
> $ ./gradlew :solr:core:test --tests
"org.apache.solr.search.TestComplexPhraseQParserPlugin.testPhraseHighlighter"
-Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC
-XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m"
-Ptests.seed=56C83FBC07AAE2C3 -Ptests.file.encoding=ISO-8859-1
> ```
yeah, this change solved the problem, But I just want to know
what was the problem here and how this change(not involving the map) solved
the problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
