magibney commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1113288086
##########
solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java:
##########
@@ -328,6 +331,17 @@ public Fields getTermVectors(int docID) throws IOException
{
return in.getTermVectors(docID);
}
+ @Override
+ public TermVectors termVectors() throws IOException {
+ return in.termVectors();
Review Comment:
`ensureOpen()` was removed as part of [this
commit](https://github.com/apache/solr/commit/797bb38c50fed9e533ca20de920c63c6c35256a9#diff-a3934253a307f6bc36771c8d549e5b5bb7bad12fd5dbe4de06e7b5ef176e2083).
Looks like an oversight perhaps. I'd be inclined to put it back (for
consistency with the other methods). @markrmiller any recollection why this was
removed? Any objection to restoring it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
