uschindler commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1124940846
##########
solr/core/src/java/org/apache/solr/core/MMapDirectoryFactory.java:
##########
@@ -63,7 +63,7 @@ protected Directory create(String path, LockFactory
lockFactory, DirContext dirC
throws IOException {
MMapDirectory mapDirectory = new MMapDirectory(Path.of(path), lockFactory,
maxChunk);
try {
- mapDirectory.setUseUnmap(unmapHack);
+ System.setProperty(MMapDirectory.ENABLE_UNMAP_HACK_SYSPROP,
String.valueOf(unmapHack));
Review Comment:
I'd still add a warning message.
The default was always "true". If somebody changed it from the default, I'd
log a warning with with the URL to the Lucene documentation as stated before.
> If we want to be nicer to users - then logging a warning is a valid option.
This would bring both together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
