dsmiley commented on PR #1360: URL: https://github.com/apache/solr/pull/1360#issuecomment-1454899402
Thanks Rob for chiming in. Made two commits. I looked at the ComplexPhraseQParser test and I don't think we should bend over backwards to support `hl.usePhraseHighlighter=false`, which is what the failing test failed to do. Trying to support it could make performance worse or extra code/complexity. It's less accurate and designed to be faster in some circumstances with older highlighters but I'd be content if this flag simply didn't exist at all. Also I noticed a commented out test that should work nowadays and it does (thanks to UnifiedHighlighter probably), so I enabled it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
