stillalex commented on code in PR #1410: URL: https://github.com/apache/solr/pull/1410#discussion_r1127114676
########## solr/core/src/test/org/apache/solr/handler/TestHttpRequestId.java: ########## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.handler; + +import java.util.concurrent.ArrayBlockingQueue; +import java.util.concurrent.BlockingQueue; +import java.util.concurrent.SynchronousQueue; +import java.util.concurrent.ThreadPoolExecutor; +import java.util.concurrent.TimeUnit; +import org.apache.solr.SolrJettyTestBase; +import org.apache.solr.client.solrj.impl.Http2SolrClient; +import org.apache.solr.client.solrj.impl.HttpListenerFactory.RequestResponseListener; +import org.apache.solr.client.solrj.request.SolrPing; +import org.apache.solr.client.solrj.util.AsyncListener; +import org.apache.solr.common.util.ExecutorUtil; +import org.apache.solr.common.util.NamedList; +import org.apache.solr.common.util.SolrNamedThreadFactory; +import org.eclipse.jetty.client.api.Request; +import org.eclipse.jetty.client.api.Result; +import org.junit.BeforeClass; +import org.junit.Test; +import org.slf4j.MDC; + +public class TestHttpRequestId extends SolrJettyTestBase { Review Comment: > You are basically saying that the improvements here are un-observable? I wonder what motivated this dubious improvement then -- something custom you have? there might be a small misunderstanding here. It's not am improvement I am chasing here, it's a bug, a regression in Solr 9 compared to Solr 8. and I don't have anything custom, this is inside the http2 client as it is used by the HttpShardHandler. I am trying to setup LogLevel + LogListener in a SolrCloudTestCase, see if I can get something better looking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
