dsmiley commented on code in PR #1410:
URL: https://github.com/apache/solr/pull/1410#discussion_r1127330844
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -447,21 +450,42 @@ public Cancellable asyncRequest(
@Override
public void onHeaders(Response response) {
super.onHeaders(response);
+ if (log.isDebugEnabled()) {
+ log.debug("response processing started");
+ }
InputStreamResponseListener listener = this;
+ MDCCopyHelper mdcCopyHelper = new MDCCopyHelper();
executor.execute(
() -> {
InputStream is = listener.getInputStream();
assert ObjectReleaseTracker.track(is);
try {
NamedList<Object> body =
processErrorsAndResponse(solrRequest, parser,
response, is);
+ mdcCopyHelper.onBegin(null);
+ if (log.isDebugEnabled()) {
Review Comment:
Can you please remove all the needless "log.isDebugEnabled" checks? It's
needlessly verbose. I suspect you are doing this because you are seeing it in
many places but we only do this when there are interpolated arguments `{}` with
non-simply references to objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
