HoustonPutman commented on code in PR #53:
URL: https://github.com/apache/solr-sandbox/pull/53#discussion_r1156250608
##########
SolrAndKafkaIntegrationTest.java:
##########
Review Comment:
I think this is a mistake as well, since its also in the test dir...
##########
crossdc-consumer/src/main/java/org/apache/solr/crossdc/consumer/KafkaCrossDcConsumer.java:
##########
@@ -220,14 +285,97 @@ boolean pollAndProcessRequests() {
return true;
}
+ public void sendBatch(UpdateRequest solrReqBatch,
ConsumerRecord<String,MirroredSolrRequest> lastRecord, WorkUnit workUnit) {
+ UpdateRequest finalSolrReqBatch = solrReqBatch;
+ Future<?> future = executor.submit(() -> {
+ IQueueHandler.Result<MirroredSolrRequest> result =
messageProcessor.handleItem(new MirroredSolrRequest(finalSolrReqBatch));
+ try {
+ processResult(lastRecord, result);
+ } catch (MirroringException e) {
+ // We don't really know what to do here
+ log.error("Mirroring exception occurred while resubmitting to Kafka.
We are going to stop the consumer thread now.", e);
Review Comment:
So this is a real error because kafka thinks the updates are processed, but
there were Solr errors and we can't resubmit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
