markrmiller commented on code in PR #53: URL: https://github.com/apache/solr-sandbox/pull/53#discussion_r1161995956
########## crossdc-producer/src/test/java/org/apache/solr/crossdc/SolrAndKafkaIntegrationTest.java: ########## @@ -64,19 +62,24 @@ protected static volatile MiniSolrCloudCluster solrCluster1; protected static volatile MiniSolrCloudCluster solrCluster2; - protected static volatile Consumer consumer = new Consumer(); + protected static volatile Consumer consumer; private static String TOPIC = "topic1"; private static String COLLECTION = "collection1"; private static String ALT_COLLECTION = "collection2"; + private static Thread.UncaughtExceptionHandler uceh; @BeforeClass Review Comment: I've switched back and forth a couple times trying to figure a fail I get with testMirroringUpdateProcessor, so it may have been off in the iteration that was up, I'm not sure, that latest is back to beforeclass, afterclass because I moved the test method that prompted that change initially into its own test class anyway. The issue I've been seeing is unrelated though - the doc that goes missing in the secondary dc is dealing with collection2 and does get cleaned up in the test method itself, and it also is an issue even when just run on it's own for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org