[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1550: True cluster join

via GitHub Fri, 07 Apr 2023 04:23:47 -0700


sonatype-lift[bot] commented on code in PR #1550:
URL: https://github.com/apache/solr/pull/1550#discussion_r1160638080



##########
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java:
##########
@@ -357,6 +372,35 @@ public List<PlacementPlan> computePlacements(
       return placementPlans;
     }
 
+    private NodePicker createNodePicker(
+        PlacementContext placementContext, PlacementRequest request, 
AttributeValues attrValues)
+        throws PlacementException {
+      if (withCollectionShards.containsKey(request.getCollection().getName())) 
{
+
+        final Set<String> shardNames = request.getCollection().getShardNames();
+        Map<String, NodePicker> byShards = new 
LinkedHashMap<>(shardNames.size());
+        for (String shardName : shardNames) {
+          byShards.put(
+              shardName,
+              new DefaultNodePicker(
+                  placementContext, request, withCollectionShards, shardName, 
attrValues));
+        }
+        return new NodePicker() {
+          @Override
+          public Set<String> getZonesFromNodes(String shardName) {
+            return byShards.get(shardName).getZonesFromNodes(shardName);
+          }
+
+          @Override
+          public Set<Node> getCandidateNodes(String shardName, 
Replica.ReplicaType replicaType) {
+            return byShards.get(shardName).getCandidateNodes(shardName, 
replicaType);

Review Comment:
   <picture><img alt="5% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/5/display.svg";></picture>
   
   <b>*NULLPTR_DEREFERENCE:</b>*  null (last assigned on line 396) is 
dereferenced.
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> 
commands</summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   <b>Help us improve LIFT! (<i>Sonatype LiftBot external survey</i>)</b>
   
   Was this a good recommendation for you? <sub><small>Answering this survey 
will not impact your Lift settings.</small></sub>
   
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=480691524&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=480691524&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=480691524&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=480691524&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=480691524&lift_comment_rating=5)
 ]



##########
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java:
##########
@@ -357,6 +372,35 @@ public List<PlacementPlan> computePlacements(
       return placementPlans;
     }
 
+    private NodePicker createNodePicker(
+        PlacementContext placementContext, PlacementRequest request, 
AttributeValues attrValues)
+        throws PlacementException {
+      if (withCollectionShards.containsKey(request.getCollection().getName())) 
{
+
+        final Set<String> shardNames = request.getCollection().getShardNames();
+        Map<String, NodePicker> byShards = new 
LinkedHashMap<>(shardNames.size());
+        for (String shardName : shardNames) {
+          byShards.put(
+              shardName,
+              new DefaultNodePicker(
+                  placementContext, request, withCollectionShards, shardName, 
attrValues));
+        }
+        return new NodePicker() {
+          @Override
+          public Set<String> getZonesFromNodes(String shardName) {
+            return byShards.get(shardName).getZonesFromNodes(shardName);

Review Comment:
   <picture><img alt="5% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/5/display.svg";></picture>
   
   <b>*NULLPTR_DEREFERENCE:</b>*  null (last assigned on line 391) is 
dereferenced.
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> 
commands</summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   <b>Help us improve LIFT! (<i>Sonatype LiftBot external survey</i>)</b>
   
   Was this a good recommendation for you? <sub><small>Answering this survey 
will not impact your Lift settings.</small></sub>
   
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=480692044&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=480692044&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=480692044&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=480692044&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=480692044&lift_comment_rating=5)
 ]



##########
solr/core/src/java/org/apache/solr/search/join/ScoreJoinQParserPlugin.java:
##########
@@ -262,7 +271,8 @@ private Query createQuery(
         if (fromIndex != null && (!fromIndex.equals(myCore) || 
byPassShortCircutCheck)) {
           CoreContainer container = req.getCoreContainer();
 
-          final String coreName = getCoreName(fromIndex, container);
+          final String coreName =
+              getCoreName(fromIndex, container, req.getCore(), toField, 
fromField);

Review Comment:
   <picture><img alt="14% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/14/display.svg";></picture>
   
   <b>*NULL_DEREFERENCE:</b>*  object `container` last assigned on line 272 
could be null and is dereferenced by call to `getCoreName(...)` at line 275.
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> 
commands</summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   <b>Help us improve LIFT! (<i>Sonatype LiftBot external survey</i>)</b>
   
   Was this a good recommendation for you? <sub><small>Answering this survey 
will not impact your Lift settings.</small></sub>
   
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=480692038&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=480692038&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=480692038&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=480692038&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=480692038&lift_comment_rating=5)
 ]



##########
solr/core/src/java/org/apache/solr/search/JoinQParserPlugin.java:
##########
@@ -153,7 +153,9 @@ JoinParams parseJoin(QParser qparser) throws SyntaxError {
         CoreContainer container = qparser.req.getCoreContainer();
 
         // if in SolrCloud mode, fromIndex should be the name of a 
single-sharded collection
-        coreName = ScoreJoinQParserPlugin.getCoreName(fromIndex, container);
+        coreName =
+            ScoreJoinQParserPlugin.getCoreName(

Review Comment:
   <picture><img alt="14% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/14/display.svg";></picture>
   
   <b>*NULL_DEREFERENCE:</b>*  object `container` last assigned on line 153 
could be null and is dereferenced by call to `getCoreName(...)` at line 157.
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> 
commands</summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   <b>Help us improve LIFT! (<i>Sonatype LiftBot external survey</i>)</b>
   
   Was this a good recommendation for you? <sub><small>Answering this survey 
will not impact your Lift settings.</small></sub>
   
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=480692397&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=480692397&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=480692397&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=480692397&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=480692397&lift_comment_rating=5)
 ]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1550: True cluster join

Reply via email to