sonatype-lift[bot] commented on code in PR #1550:
URL: https://github.com/apache/solr/pull/1550#discussion_r1161101152
##########
solr/core/src/java/org/apache/solr/search/join/ScoreJoinQParserPlugin.java:
##########
@@ -262,7 +271,8 @@ private Query createQuery(
if (fromIndex != null && (!fromIndex.equals(myCore) ||
byPassShortCircutCheck)) {
CoreContainer container = req.getCoreContainer();
- final String coreName = getCoreName(fromIndex, container);
+ final String coreName =
+ getCoreName(fromIndex, container, req.getCore(), toField,
fromField);
Review Comment:
I've recorded this as ignored for this pull request.
If you change your mind, just comment `@sonatype-lift unignore`.
##########
solr/core/src/java/org/apache/solr/search/JoinQParserPlugin.java:
##########
@@ -153,7 +153,9 @@ JoinParams parseJoin(QParser qparser) throws SyntaxError {
CoreContainer container = qparser.req.getCoreContainer();
// if in SolrCloud mode, fromIndex should be the name of a
single-sharded collection
- coreName = ScoreJoinQParserPlugin.getCoreName(fromIndex, container);
+ coreName =
+ ScoreJoinQParserPlugin.getCoreName(
Review Comment:
I've recorded this as ignored for this pull request.
If you change your mind, just comment `@sonatype-lift unignore`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
