janhoy commented on code in PR #1653:
URL: https://github.com/apache/solr/pull/1653#discussion_r1221397502
##########
gradle/validation/forbidden-apis.gradle:
##########
@@ -49,11 +49,6 @@ allprojects { prj ->
logger.debug("Signature file omitted (does not exist): ${sig}")
}
}
-
- // commons-io is special: forbiddenapis has a versioned bundledSignature.
- bundledSignatures += resolvedMods
- .findAll { id -> id.group == 'commons-io' && id.name == 'commons-io' }
- .collect { id -> "${id.name}-unsafe-${id.version}" as String }
Review Comment:
I see that forbidden-apis probably needs a new file like
https://github.com/policeman-tools/forbidden-apis/blob/main/src/main/resources/de/thetaphi/forbiddenapis/signatures/commons-io-unsafe-2.11.0.txt
- for 2.12. But if there are no new unsafe APIs in 2.12 we could perhaps use
`commons-io-unsafe-2.11.0` for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
