uschindler commented on code in PR #1653:
URL: https://github.com/apache/solr/pull/1653#discussion_r1222743381
##########
gradle/validation/forbidden-apis.gradle:
##########
@@ -49,11 +49,13 @@ allprojects { prj ->
logger.debug("Signature file omitted (does not exist): ${sig}")
}
}
-
+
// commons-io is special: forbiddenapis has a versioned bundledSignature.
- bundledSignatures += resolvedMods
- .findAll { id -> id.group == 'commons-io' && id.name == 'commons-io' }
- .collect { id -> "${id.name}-unsafe-${id.version}" as String }
+// bundledSignatures += resolvedMods
+// .findAll { id -> id.group == 'commons-io' && id.name == 'commons-io'
}
+// .collect { id -> "${id.name}-unsafe-${id.version}" as String }
+ // Hack until forbiddenapis supports commons-io 2.12.0
+ bundledSignatures += ['commons-io-unsafe-2.11.0']
Review Comment:
This now adds commons-io to all Solr modules, although it may not be part of
dependencies. This should not hurt, but could cause failures if we have a Solr
module that does not refer to commons-io.
I'd change only line 56 to be:
```groovy
.collect { id -> "${id.name}-unsafe-2.11.0" as String }
```
This ensures the forbiddenapis are only added if the compilation unit
depends on commons-io.
Maybe keep the existing line commented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
