mkhludnev commented on code in PR #1691:
URL: https://github.com/apache/solr/pull/1691#discussion_r1251911992
##########
solr/core/src/java/org/apache/solr/search/join/ScoreJoinQParserPlugin.java:
##########
@@ -355,17 +377,114 @@ private static String resolveAlias(String fromIndex,
ZkController zkController)
}
}
- private static String findLocalReplicaForFromIndex(ZkController
zkController, String fromIndex) {
- String fromReplica = null;
+ private static String findLocalReplicaForFromIndex(
+ ZkController zkController,
+ String fromIndex,
+ SolrCore toCore,
+ String toField,
+ String fromField,
+ SolrParams localParams) {
+ final DocCollection fromCollection =
zkController.getClusterState().getCollection(fromIndex);
+ final String nodeName = zkController.getNodeName();
+ if (fromCollection.getSlices().size() == 1) {
+ return getLocalSingleShard(zkController, fromIndex);
+ } else { // sharded from
+ final CloudDescriptor toCoreDescriptor =
toCore.getCoreDescriptor().getCloudDescriptor();
+ final DocCollection toCollection =
+
zkController.getClusterState().getCollection(toCoreDescriptor.getCollectionName());
+
+ boolean isFromSiteCheckRequired =
Review Comment:
typo > side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
