[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1691: SOLR-16717: Join multiple distributed shards

[via GitHub]

sonatype-lift[bot] commented on code in PR #1691:
URL: https://github.com/apache/solr/pull/1691#discussion_r1252118375


##########
solr/core/src/java/org/apache/solr/search/join/ScoreJoinQParserPlugin.java:
##########
@@ -388,10 +510,88 @@ private static String 
findLocalReplicaForFromIndex(ZkController zkController, St
     }
 
     if (fromReplica == null)
+      throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, 
USE_CROSSCOLLECTION);
+
+    return fromReplica;
+  }
+
+  private static void checkSliceRanges(
+      DocCollection toCollection, DocCollection fromCollection, String 
shardId) {
+    final DocRouter.Range toRange = toCollection.getSlice(shardId).getRange();

Review Comment:
   <picture><img alt="7% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/7/display.svg";></picture>
   
   <b>*NULLPTR_DEREFERENCE:</b>*  `Slice DocCollection.getSlice(String)` could 
be null (from the call to `DocCollection.getSlice(...)` on line 520) and is 
dereferenced.
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> 
commands</summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org