[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1762: SOLR-16871: Race condition in `CoordinatorHttpSolrCall` synthetic collection/replica init

[via GitHub]

sonatype-lift[bot] commented on code in PR #1762:
URL: https://github.com/apache/solr/pull/1762#discussion_r1255011962


##########
solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java:
##########
@@ -111,6 +131,21 @@ public static SolrCore getCore(
           }
 
           addReplica(syntheticCollectionName, solrCall.cores);
+        } else {
+          //still have to ensure that it's active, otherwise 
super.getCoreByCollection will return null
+          //and then CoordinatorHttpSolrCall will call getCore again hence 
creating a calling loop
+          try {
+            zkStateReader.waitForState(syntheticCollectionName, 10, 
TimeUnit.SECONDS, docCollection -> {
+              for (Replica nodeNameSyntheticReplica : 
docCollection.getReplicas(solrCall.cores.getZkController().getNodeName())) {

Review Comment:
   <picture><img alt="7% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/7/display.svg";></picture>
   
   <b>*NULLPTR_DEREFERENCE:</b>*  `List DocCollection.getReplicas(String)` 
could be null (from the call to `DocCollection.getReplicas(...)` on line 139) 
and is dereferenced.
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> 
commands</summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   



##########
solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java:
##########
@@ -111,6 +131,21 @@ public static SolrCore getCore(
           }
 
           addReplica(syntheticCollectionName, solrCall.cores);
+        } else {
+          //still have to ensure that it's active, otherwise 
super.getCoreByCollection will return null
+          //and then CoordinatorHttpSolrCall will call getCore again hence 
creating a calling loop
+          try {
+            zkStateReader.waitForState(syntheticCollectionName, 10, 
TimeUnit.SECONDS, docCollection -> {
+              for (Replica nodeNameSyntheticReplica : 
docCollection.getReplicas(solrCall.cores.getZkController().getNodeName())) {
+                if (nodeNameSyntheticReplica.getState() == 
Replica.State.ACTIVE) {
+                  return true;
+                }
+              }
+              return false;
+            });
+          } catch (Exception e) {
+            throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, 
"Failed to wait for active replica for synthetic collection [" + 
syntheticCollectionName + "]", e);
+          }
         }
         core = solrCall.getCoreByCollection(syntheticCollectionName, 
isPreferLeader);

Review Comment:
   <picture><img alt="7% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/7/display.svg";></picture>
   
   <b>*THREAD_SAFETY_VIOLATION:</b>*  Unprotected write. Non-private method 
`CoordinatorHttpSolrCall.getCore(...)` indirectly mutates container 
`core.SolrResourceLoader.classNameCache` via call to `Map.put(...)` outside of 
synchronization.
    Reporting because a superclass `class org.apache.solr.servlet.HttpSolrCall` 
is annotated `@ThreadSafe`, so we assume that this method can run in parallel 
with other non-private methods in the class (including itself).
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> 
commands</summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org