patsonluk commented on code in PR #1762:
URL: https://github.com/apache/solr/pull/1762#discussion_r1260270218
##########
solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java:
##########
@@ -208,9 +208,12 @@ private static void setMDCLoggingContext(String
collectionName) {
private static void addReplica(String syntheticCollectionName, CoreContainer
cores) {
SolrQueryResponse rsp = new SolrQueryResponse();
try {
+ String coreName = syntheticCollectionName + "_" + "r1";
Review Comment:
Good to know! 👍🏼
In this case we might want to always call `waitForState` as in
https://github.com/apache/solr/pull/1762/files#diff-eedf409265fc219f98f193ae89d3f1b09df78fe49f70bb5b9eaa6c6ff46e6ac7R143
since `addReplica` can now return while the target replica is still under
construction by another request.
##########
solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java:
##########
@@ -208,9 +208,12 @@ private static void setMDCLoggingContext(String
collectionName) {
private static void addReplica(String syntheticCollectionName, CoreContainer
cores) {
SolrQueryResponse rsp = new SolrQueryResponse();
try {
+ String coreName = syntheticCollectionName + "_" + "r1";
Review Comment:
Good to know! 👍🏼
In this case we might want to always call `waitForState` as in
https://github.com/apache/solr/pull/1762/files#diff-eedf409265fc219f98f193ae89d3f1b09df78fe49f70bb5b9eaa6c6ff46e6ac7R143
since `addReplica` can now return while the target replica is still under
construction by another request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
