patsonluk commented on code in PR #1762:
URL: https://github.com/apache/solr/pull/1762#discussion_r1261432135
##########
solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java:
##########
@@ -208,9 +208,12 @@ private static void setMDCLoggingContext(String
collectionName) {
private static void addReplica(String syntheticCollectionName, CoreContainer
cores) {
SolrQueryResponse rsp = new SolrQueryResponse();
try {
+ String coreName = syntheticCollectionName + "_" + "r1";
Review Comment:
Thank you @noblepaul !
I added another small commit 45654e1c5bff66413956202cade3d1b75733be17 on
`TestCoordinatorRole` to ensure that the fix work:
1. Changed coordinator node count 2 -> 4
2. Verified the replica count on the synthetic collection
Also a minor change to the addReplica flow, that we always check for replica
status afterwards (since `addReplica` might now return if exception is thrown
and caught, and with replica status not always active, we could run into
infinite call loop, this is a rather rare case, but it doesn't hurt to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
