[ 
https://issues.apache.org/jira/browse/SOLR-16812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745102#comment-17745102
 ] 

Jason Gerlowski commented on SOLR-16812:
----------------------------------------

bq. If you think the performance is slower, please share your findings.

I don't think Mark is making a claim about the performance one way or another; 
I think his concern is more around "process".

There was no attempt here to reach consensus on what should be tested  (e.g. 
the range of data sizes, numDocs, distribution of field types, etc.) prior to 
doing the tests.  There was no real detailed description of what the tests did 
(beyond a "I used this batch size and here's the code if you'd like").  And 
when folks did read the code and had questions/concerns, they [mostly went 
ignored|https://github.com/apache/solr/pull/1655#discussion_r1218294026].

I think CBOR is a Great Thing for Solr, because it gets us closer to getting 
out of the custom-binary-format business.  I'm all for it.  But I think there 
were real process lapses that Mark is gesturing towards here.

> Support CBOR format for update/query
> ------------------------------------
>
>                 Key: SOLR-16812
>                 URL: https://issues.apache.org/jira/browse/SOLR-16812
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Major
>             Fix For: 9.3
>
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> Javabin is quite efficient and fast . But non-java users have to use JSON 
> exclusively
>  
> [CBOR |http://example.com/] is a widely used format that is supported by most 
> languages. 
>  
> Here is a benchmark of updating using CBOR vs. JSON our films.json
> {code:java}
> Payload Size (bytes)
> ============
>  
> json : 633600
> cbor : 210439  
> javabin: 234520
> time taken to index
> ====================
> JSON: 330ms
> JAVABIN: 216ms
> CBOR: 200ms
> time takes to query *:* 1100 docs
> ==================================
> json: 85 ms
> javabin : 64ms 
> cbor : 53ms{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to