dsmiley commented on PR #1793: URL: https://github.com/apache/solr/pull/1793#issuecomment-1652161175
> We could move the -API suffix to the interfaces and give the actual implementations an "-Impl" suffix Yes I think we should do that. If our existing "API" classes *implement* the API, and we are introducing a new interface distinction that previously didn't exist then let's incorporate "Impl" into the name of the existing classes. Even if it means a bunch of renames. The "Impl" suffix is kinda common in such approaches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
