HoustonPutman commented on PR #1793: URL: https://github.com/apache/solr/pull/1793#issuecomment-1652481090
> Would we really need to make the 'api' module "opt-in" for 9.x? I'm sure I'm showing my naiveté here, but client libraries change their deps all the time in non-major releases, don't they? What benefit does "opt-in" get our users? I don't think it's possible to make the `api` module "opt-in". This is a first class feature, that's going to be intertwined with SolrJ. > 😬 As things are today, SolrJ **is** dependent on the 'api' module. The generated SolrRequest files are copied over to SolrJ and built into that jar, but those SolrRequest files rely on POJO classes from 'api' to represent the request and response bodies. Ahh that makes sense, I guess having `api` be a dependency is of very little consequence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
