epugh commented on code in PR #1808:
URL: https://github.com/apache/solr/pull/1808#discussion_r1276281337
##########
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##########
@@ -383,6 +383,11 @@ public static boolean exceptionIsAuthRelated(Exception
exc) {
}
public static SolrClient getSolrClient(String solrUrl) {
+ // today we require all urls to end in /solr, however in the future we
will need to support the
+ // /api url end point instead.
+ if (!solrUrl.endsWith(("/solr"))) {
Review Comment:
So this kind of made me sad... basically I was trying to write both code to
handle legacy /solr type urls, but then, since everything TODAY requries a
/solr url, then to inject it here. Have we figured out how in the future to
hit a V2 api that has an /api end point instead via a SolrClient? My hope is
once that is solved then we remove this logic.
Having said that, if there is better code to use here, would love some of
that! I hope that before 10x gets released, this code will be eliminated, so
I kind of just put this in "for now".... I don't expect to backport this to
9x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
