epugh commented on code in PR #1808: URL: https://github.com/apache/solr/pull/1808#discussion_r1276630658
########## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ########## @@ -383,6 +383,11 @@ public static boolean exceptionIsAuthRelated(Exception exc) { } public static SolrClient getSolrClient(String solrUrl) { + // today we require all urls to end in /solr, however in the future we will need to support the + // /api url end point instead. + if (!solrUrl.endsWith(("/solr"))) { Review Comment: Oh wait... why do tests now have solr urls that end in `/solr`??? Now I wonder if they also stand up Solr servers that don't use `/api` for the v2 api endpoint? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org