risdenk commented on code in PR #1789:
URL: https://github.com/apache/solr/pull/1789#discussion_r1283640058
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -755,11 +762,12 @@ private Request fillContentStream(
content.addFilePart(
name,
contentStream.getName(),
- new InputStreamContentProvider(contentStream.getStream()),
+ new InputStreamRequestContent(contentStream.getStream()),
fields);
}
}
- req.content(content);
+ content.close();
Review Comment:
Do we have to worry about closing this if there is an exception? not sure if
`MultiPartRequestContent` can do try w/ resources?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
