stillalex commented on code in PR #1789:
URL: https://github.com/apache/solr/pull/1789#discussion_r1286170365
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -438,81 +436,78 @@ public void send(OutStream outStream, SolrRequest<?> req,
String collection) thr
private static final Cancellable FAILED_MAKING_REQUEST_CANCELLABLE = () ->
{};
public Cancellable asyncRequest(
- SolrRequest<?> solrRequest,
- String collection,
- AsyncListener<NamedList<Object>> asyncListener) {
+ SolrRequest<?> solrReq, String collection,
AsyncListener<NamedList<Object>> asyncListener) {
+ MDCCopyHelper mdcCopyHelper = new MDCCopyHelper();
+ SolrRequest<?> solrRequest = unwrapV2Request(solrReq);
+
Request req;
try {
- req = makeRequest(solrRequest, collection);
- } catch (SolrServerException | IOException e) {
- asyncListener.onFailure(e);
- return FAILED_MAKING_REQUEST_CANCELLABLE;
- }
- final ResponseParser parser =
- solrRequest.getResponseParser() == null ? this.parser :
solrRequest.getResponseParser();
- MDCCopyHelper mdcCopyHelper = new MDCCopyHelper();
- req.onRequestQueued(asyncTracker.queuedListener)
- .onComplete(asyncTracker.completeListener)
- .send(
- new InputStreamResponseListener() {
- @Override
- public void onHeaders(Response response) {
- super.onHeaders(response);
- InputStreamResponseListener listener = this;
- executor.execute(
- () -> {
- InputStream is = listener.getInputStream();
- assert ObjectReleaseTracker.track(is);
- try {
- NamedList<Object> body =
- processErrorsAndResponse(
- solrRequest, parser, response, is,
req.getURI().toString());
+ String url = getRequestPath(solrRequest, collection);
+ InputStreamResponseListener listener =
+ new InputStreamResponseListener() {
+ @Override
+ public void onHeaders(Response response) {
+ super.onHeaders(response);
+ InputStreamResponseListener listener = this;
Review Comment:
does not seem to be needed. weird, removed it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
