psalagnac commented on code in PR #1761:
URL: https://github.com/apache/solr/pull/1761#discussion_r1288526660
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java:
##########
@@ -506,30 +507,23 @@ private static NamedList<Object>
waitForCoreAdminAsyncCallToComplete(
}
String r = (String)
srsp.getSolrResponse().getResponse().get("STATUS");
- if (r.equals("running")) {
Review Comment:
We don't check an enum, but string values.
I often feel a `switch` statement on strings is error prone, and doesn't
protect from regressions.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
