psalagnac commented on code in PR #1761:
URL: https://github.com/apache/solr/pull/1761#discussion_r1289053033


##########
solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java:
##########
@@ -506,30 +507,23 @@ private static NamedList<Object> 
waitForCoreAdminAsyncCallToComplete(
           }
 
           String r = (String) 
srsp.getSolrResponse().getResponse().get("STATUS");
-          if (r.equals("running")) {

Review Comment:
   I may miss something. Do you suggest to introduce a new enum for this? I 
don't think there is one for request statuses.
   Here `PENDING` is just a constant string.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to