risdenk commented on code in PR #1835:
URL: https://github.com/apache/solr/pull/1835#discussion_r1290795542
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/CommitStream.java:
##########
@@ -55,6 +55,7 @@ public class CommitStream extends TupleStream implements
Expressible {
private TupleStream tupleSource;
private transient SolrClientCache clientCache;
+ private transient boolean isCloseCache;
Review Comment:
Do we need this new boolean `isCloseCache`? Can't we just check if
`clientCache == null` in the close method and set it to `clientCache = null`
after `clientCache.close();`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
