stillalex commented on code in PR #1835:
URL: https://github.com/apache/solr/pull/1835#discussion_r1291836322
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/SolrClientCache.java:
##########
@@ -40,85 +43,131 @@
*
* <p>TODO: Cut this over to using Solr's new Http2 clients
*/
-public class SolrClientCache implements Serializable {
+public class SolrClientCache implements Serializable, Closeable {
Review Comment:
> Maybe a subclass approach would work better
I am not convinced. the complexity comes from the streaming code that has a
lot of ins and outs. ideally it would work both types of clients irrespective
of where they come from (internal node communication or external apps). I don't
think the code would be as clean, but I can definitely give it a go and see
what fits better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
