stillalex commented on code in PR #1835:
URL: https://github.com/apache/solr/pull/1835#discussion_r1292328290
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/Facet2DStream.java:
##########
@@ -325,13 +322,7 @@ public void open() throws IOException {
if (cache != null) {
cloudSolrClient = cache.getCloudSolrClient(zkHost);
} else {
- final List<String> hosts = new ArrayList<>();
- hosts.add(zkHost);
- cloudSolrClient =
- new CloudLegacySolrClient.Builder(hosts, Optional.empty())
- .withSocketTimeout(30000, TimeUnit.MILLISECONDS)
- .withConnectionTimeout(15000, TimeUnit.MILLISECONDS)
- .build();
+ cloudSolrClient = SolrClientCache.newCloudHttp2SolrClient(zkHost, null);
Review Comment:
@dsmiley did a complete pass over all classes and moved everything to cache.
please take a look.
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/SolrClientCache.java:
##########
@@ -40,85 +43,131 @@
*
* <p>TODO: Cut this over to using Solr's new Http2 clients
Review Comment:
line removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
