stillalex commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1303292779
########## solr/core/src/java/org/apache/solr/core/NodeConfig.java: ########## @@ -567,6 +575,7 @@ public static class NodeConfigBuilder { private String defaultZkHost; private Set<Path> allowPaths = Collections.emptySet(); private List<String> allowUrls = Collections.emptyList(); + private boolean hideStackTrace = false; Review Comment: the default should be the system property value I think. this way it's consistent with the ResponseUtils implementation. (if you only set the system property, both code paths should behave the same) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org